Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closed chan read 2 #3438

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Sep 5, 2023

Close: aquasecurity/libbpfgo#122

1. Explain what the PR does

eebd7e7 fix(ebpf): close perfbuf instead of just stop
667a863 fix(ebpf): closed channel read

eebd7e7 fix(ebpf): close perfbuf instead of just stop

This was an old TODO comment removed by https://github.com/aquasecurity/tracee/pull/296/files#diff-82aa2eb77c3ce782b8ebfb70eaba8a1a5a8a2dce9f3349352a3a3c0f909478f1L604

667a863 fix(ebpf): closed channel read

This libbpfgo issue aquasecurity/libbpfgo#122
is actually a Tracee problem. It was caused by read attempts on a
closed channel (lostEvChannel), when libbpgo had already closed it.

2. Explain how to test it

Run tracee and kill it via ^C.

3. Other comments

This libbpfgo issue aquasecurity/libbpfgo#122
is actually a Tracee problem. It was caused by read attempts on a
closed channel (lostEvChannel), when libbpgo had already closed it.
@geyslan geyslan merged commit dfe9687 into aquasecurity:main Sep 11, 2023
27 checks passed
@geyslan geyslan deleted the fix-process-lost-events branch September 18, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero lost events counter on callback
2 participants